Include missing headers

[MichaelChirico]

• cpp11.cpp: <cstddef> for ptrdiff_t
• vroom_write.cc: for <functional> std::cref

---

Our tooling also recommends directly including the following cpp11 headers to src/cpp11.cpp, but I omitted that as it feels more stylistic:

• "cpp11/as.hpp" for as_cpp and as_sexp
• "cpp11/integers.hpp" for integers

Happy to update the patch to include those if desired.

[jennybc]

This is a generated file, so if this is important, we'll have to make different arrangements.

[DavisVaughan]

I think if we were going to put this anywhere, it would be in vroom_types.h, since the idea of that file is that it gets automatically included here to provide the definitions for any types needed to support this autogenerated file, like vroom_errors

vroom/src/cpp11.cpp

Line 87 in 27285a6

cpp11::data_frame vroom_errors_(cpp11::external_pointer<std::shared_ptr<vroom_errors>> errors);

But I'm not super worried about this one because cpp11/declarations.hpp includes cpp11/cpp11.hpp which includes all of cpp11, and cpp11/r_vector.hpp includes <stddef.h> which is where ptrdiff_t is (https://cplusplus.com/reference/cstddef/) and I don't really see that changing. Typically I am more worried about implicit dependencies like this, but this file is kind of an exception.

---

AFAICT, it was very intentional that cpp11/declarations.hpp includes cpp11/cpp11.hpp. It basically includes that file + adds a few other declarations needed for code.cpp. But the idea is that including cpp11/declarations.hpp is "enough" to generate code.cpp without any other cpp11 headers. So we don't need to add cpp11/as.hpp or cpp11/integers.hpp either
https://github.com/r-lib/cpp11/blob/500f642b4ea132ec8c168fc70a28e81e9510ece3/inst/include/cpp11/declarations.hpp#L7-L16

[MichaelChirico]

I think if CRAN starts enforcing on this clang finding, it's gonna be chaos for sure.

[jennybc]

So we're agreed, I think, that this change should be reverted.

Then I'll merge the PR with the remaining change.

[jennybc]

Seems fine to me. Do you have an opinion @DavisVaughan?

[DavisVaughan]

Looks right to me since cref() does indeed come from <functional>
https://en.cppreference.com/w/cpp/utility/functional/ref

[jennybc]

Thanks!