Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading list of connections #514

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Allow reading list of connections #514

merged 4 commits into from
Sep 26, 2023

Conversation

bairdj
Copy link
Contributor

@bairdj bairdj commented Sep 26, 2023

Fixes #509

This amends standardise_path to work with a list of connections, as referred to in the vignette.

The test for this functionality "vroom works with many connections" was incorrectly passing a character vector of paths to vroom instead of a list of connections, so this wasn't being picked up as a failing test.

@jennybc
Copy link
Member

jennybc commented Sep 26, 2023

Thanks! I'm going to merge this, then make some refinements after the fact FYI.

The test for this functionality "vroom works with many connections" was incorrectly passing a character vector of paths to vroom instead of a list of connections, so this wasn't being picked up as a failing test.

It's not very apparent, but reading from *.csv.gz files actually hits the connections code path. So the pre-existing test does actually do what it claims, in a way.

@jennybc jennybc merged commit 6a320a7 into tidyverse:main Sep 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vroom does not work on list of connections
2 participants