Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectangling function rewrite #1200

Merged
merged 17 commits into from
Nov 15, 2021
Merged

Rectangling function rewrite #1200

merged 17 commits into from
Nov 15, 2021

Commits on Nov 15, 2021

  1. Implement tidyr_chop2() 

    Since we don't have `vec_chop2()` yet r-lib/vctrs#1226
    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    5bb8b5a View commit details
    Browse the repository at this point in the history

  2. Add list_of_ptype() helper for consistent list-of ptype extraction

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    455a64d View commit details
    Browse the repository at this point in the history

  3. Generalize unchop_col_info() into list_init_empty() 

    This will be useful for an enhanced `simplify_col()`
    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    871915a View commit details
    Browse the repository at this point in the history

  4. Rename tidyr_chop2() to tidyr_chop()

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    6cd377c View commit details
    Browse the repository at this point in the history

  5. Reimplement rectangling functions

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    4051cd4 View commit details
    Browse the repository at this point in the history

  6. NEWS bullet

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    1c37b67 View commit details
    Browse the repository at this point in the history

  7. Move details about ptype and transform to the transform param docs

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    66e777c View commit details
    Browse the repository at this point in the history

  8. Link to list_of() documentation

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    3294bbf View commit details
    Browse the repository at this point in the history

  9. Mention recycling of unnest_longer()

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    bc7a16a View commit details
    Browse the repository at this point in the history

  10. Synchronize values_to and indices_to documentation

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    c766f46 View commit details
    Browse the repository at this point in the history

  11. Replace "can't" with "must not"

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    bbe1ad2 View commit details
    Browse the repository at this point in the history

  12. Introduce tidyr_temporary_new_list_of() 

    Because vctr objects can't currently have `""` names
    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    65735a7 View commit details
    Browse the repository at this point in the history

  13. Provide more input validation for ptype and transform

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    817af55 View commit details
    Browse the repository at this point in the history

  14. Add two tests about names_sep, provided by @mgirlich

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    7e3b4fa View commit details
    Browse the repository at this point in the history

  15. Chop non-lists into lists with vec_chop() 

    This uses more explainable vctrs tooling for converting non-primary data types (i.e. non-lists) into lists. This also seems to produce the expected output in more scenarios.

Also inlined `tidyr_chop()` into `elt_to_wide()` since that is the only other place it was used. The fact that this removed a helper makes me optimistic that it is the right approach.
    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    c8c9b3f View commit details
    Browse the repository at this point in the history

  16. Test that df-cols result in list-ofs when simplify = FALSE

    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    bf936c0 View commit details
    Browse the repository at this point in the history

  17. Apply unique name repair on names before applying names_sep 

    Applying it before `names_sep` rather than after means that `""` and `NA_character_` names get repaired early on before they are combined with the prefix and `names_sep`, which can make them mistakently look like "valid" names
    @DavisVaughan
    DavisVaughan committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    e0d0d18 View commit details
    Browse the repository at this point in the history