Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hms class rather than custom time class #425

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

jimhester
Copy link
Collaborator

The only real issue is arithmetic on hms objects drops the hms class (tidyverse/hms#18), so I had to coerce back to hms objects in the tests.

Fixes #409

@hadley
Copy link
Member

hadley commented Jun 8, 2016

LGTM

@jimhester jimhester merged commit 4fef7d6 into tidyverse:master Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants