Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options(readr.show_col_types=FALSE) is not work on read_table() #1331

Closed
BowenXiao123 opened this issue Nov 22, 2021 · 0 comments · Fixed by #1332
Closed

options(readr.show_col_types=FALSE) is not work on read_table() #1331

BowenXiao123 opened this issue Nov 22, 2021 · 0 comments · Fixed by #1332

Comments

@BowenXiao123
Copy link

options(readr.show_col_types=FALSE) is not work on read_table() and read_table is not allow set the parameter in the function for example:
read_table(show_col_types=FALSE)
jimhester added a commit that referenced this issue Nov 22, 2021
@jimhester
Add support for show_col_types for edition 1 parser
57f30bb 
`read_table()` is one of the functions that currently doesn't have a
vroom equivalent, so is still using the first edition parser. When we
added support for `show_col_types` we didn't port that back to the first
edition parser, so it was missing in `read_table()` and the
`read_delim_chunked()` functions.

Fixes #1331
@jimhester jimhester mentioned this issue Nov 22, 2021
Merged
jennybc pushed a commit that referenced this issue Nov 29, 2021
@jimhester @jennybc
Add support for show_col_types for edition 1 parser
0c11f23 
`read_table()` is one of the functions that currently doesn't have a
vroom equivalent, so is still using the first edition parser. When we
added support for `show_col_types` we didn't port that back to the first
edition parser, so it was missing in `read_table()` and the
`read_delim_chunked()` functions.

Fixes #1331
jennybc pushed a commit that referenced this issue Nov 29, 2021
@jimhester @jennybc
Add support for show_col_types for edition 1 parser
ce8b97e 
`read_table()` is one of the functions that currently doesn't have a
vroom equivalent, so is still using the first edition parser. When we
added support for `show_col_types` we didn't port that back to the first
edition parser, so it was missing in `read_table()` and the
`read_delim_chunked()` functions.

Fixes #1331
jennybc pushed a commit that referenced this issue Nov 30, 2021
@jimhester @jennybc
Add support for show_col_types for edition 1 parser
427fb81 
`read_table()` is one of the functions that currently doesn't have a
vroom equivalent, so is still using the first edition parser. When we
added support for `show_col_types` we didn't port that back to the first
edition parser, so it was missing in `read_table()` and the
`read_delim_chunked()` functions.

Fixes #1331
jennybc pushed a commit that referenced this issue Nov 30, 2021
@jimhester @jennybc
Add support for show_col_types for edition 1 parser
f25787c 
`read_table()` is one of the functions that currently doesn't have a
vroom equivalent, so is still using the first edition parser. When we
added support for `show_col_types` we didn't port that back to the first
edition parser, so it was missing in `read_table()` and the
`read_delim_chunked()` functions.

Fixes #1331
jennybc added a commit that referenced this issue Nov 30, 2021
@jimhester @jennybc
Add support for show_col_types for edition 1 parser (#1332)
a14f189 
* Add support for show_col_types for edition 1 parser

`read_table()` is one of the functions that currently doesn't have a
vroom equivalent, so is still using the first edition parser. When we
added support for `show_col_types` we didn't port that back to the first
edition parser, so it was missing in `read_table()` and the
`read_delim_chunked()` functions.

Fixes #1331

* Remove should_show_col_types

This is the helper we use in vroom, but I think having it in readr would
be too confusing because we already have should_show_types

* Correct function name

* document()

* Update NEWS.md

* Reformat for readability

* Refactor should_show_types(); add tests

* Move NEWS bullet

Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for show_col_types for edition 1 parser tidyverse/readr
1 participant
@BowenXiao123