Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative durations are displayed as positive #719

Closed
jfritzemeier opened this issue Sep 24, 2018 · 1 comment
Closed

Negative durations are displayed as positive #719

jfritzemeier opened this issue Sep 24, 2018 · 1 comment
Labels
bug an unexpected problem or unintended behavior wip work in progress

Comments

@jfritzemeier
Copy link

Title says it all (sry for the bad formatting):

x
[1] "47s" "221s (~3.68 minutes)" "31s"
[4] "7s" "791s (~13.18 minutes)" "29s"
dput(x)
new("Duration", .Data = c(47, -221, 31, 7, -791, 29))

Here the -221 seconds are displayed as ~3.68 minutes. There is no clue that this is actually negative. This is a major issue when debugging. Especially when doing comparisons like:

x <= dseconds(59)
hglanz added a commit to hglanz/lubridate that referenced this issue Jan 19, 2019
@hglanz
Issue tidyverse#719 - Changed Duration format to correctly display ne…
29b7d0d 
…gative values.
@hglanz
Copy link

hglanz commented Jan 19, 2019

I am working on this for Tidyverse Dev Day 2019

hglanz added a commit to hglanz/lubridate that referenced this issue Jan 20, 2019
@hglanz
Issue tidyverse#719 - Prepends negative sign to durations created wit…
3b451a6 
…h negative values

Negative durations were not being printed properly; they looked positive. This one line addition prepends a negative sign to durations created from negative values.

When the package is tested I get 4 failures, but I get these same 4 failures with no changes to the package code. So, I'm unsure how to resolve this.
hglanz added a commit to hglanz/lubridate that referenced this issue Jan 20, 2019
@hglanz
Issue tidyverse#719 - Reverted back to using abs() on input to comput…
1adb026 
…e_estimate as in original package code
@hglanz hglanz mentioned this issue Nov 19, 2019
Closed
@hadley hadley added bug an unexpected problem or unintended behavior wip work in progress labels Nov 19, 2019
@vspinu vspinu closed this as completed in 6675469 Dec 7, 2019
vspinu added a commit that referenced this issue Dec 7, 2019
@vspinu
[Fix #719] Print negative durations with leading -
d467706
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 30, 2021
(time/R-lubridate) Updated 1.7.4 to 1.7.10
e7d191b 
Version 1.7.10
==============

### NEW FEATURES

* `fast_strptime()` and `parse_date_time2()` now accept multiple formats and apply them in turn

### BUG FIXES

* [#926](tidyverse/lubridate#926) Fix incorrect division of intervals by months involving leap years
* Fix incorrect skipping of digits during parsing of the `%z` format

Version 1.7.9.2
===============

### NEW FEATURES

* [#914](tidyverse/lubridate#914) New `rollforward()` function
* [#928](tidyverse/lubridate#928) On startup lubridate now resets TZDIR to a proper directory when it is set to non-dir values like "internal" or "macOS" (a change introduced in R4.0.2)
* [#630](tidyverse/lubridate#630) New parsing functions `ym()` and `my()`

### BUG FIXES

* [#930](tidyverse/lubridate#930) `as.period()` on intervals now returns valid Periods with double fields (not integers)



Version 1.7.9
=============

### NEW FEATURES

* [#871](tidyverse/lubridate#893) Add `vctrs` support


### BUG FIXES

* [#890](tidyverse/lubridate#890) Correctly compute year in `quarter(..., with_year = TRUE)`
* [#893](tidyverse/lubridate#893) Fix incorrect parsing of abbreviated months in locales with trailing dot (regression in v1.7.8)
* [#886](tidyverse/lubridate#886) Fix `with_tz()` for POSIXlt objects
* [#887](tidyverse/lubridate#887) Error on invalid numeric input to `month()`
* [#889](tidyverse/lubridate#889) Export new dmonth function

Version 1.7.8
=============

### NEW FEATURES

* (breaking) Year and month durations now assume 365.25 days in a year consistently in conversion and constructors. Particularly `dyears(1) == years(1)` is now `TRUE`.
* Format and print methods for 0-length objects are more consistent.
* New duration constructor `dmonths()` to complement other duration constructors.
*
* `duration()` constructor now accepts `months` and `years` arguments.
* [#629](tidyverse/lubridate#629) Added `format_ISO8601()` methods.
* [#672](tidyverse/lubridate#672) Eliminate all partial argument matches
* [#674](tidyverse/lubridate#674) `as_date()` now ignores the `tz` argument
* [#675](tidyverse/lubridate#675) `force_tz()`, `with_tz()`, `tz<-` convert dates to date-times
* [#681](tidyverse/lubridate#681) New constants `NA_Date_` and `NA_POSIXct_` which parallel built-in primitive constants.
* [#681](tidyverse/lubridate#681) New constructors `Date()` and `POSIXct()` which parallel built-in primitive constructors.
* [#695](tidyverse/lubridate#695) Durations can now be compared with numeric vectors.
* [#707](tidyverse/lubridate#707) Constructors return 0-length inputs when called with no arguments
* [#713](tidyverse/lubridate#713) (breaking) `as_datetime()` always returns a `POSIXct()`
* [#717](tidyverse/lubridate#717) Common generics are now defined in `generics` dependency package.
* [#719](tidyverse/lubridate#719) Negative Durations are now displayed with leading `-`.
* [#829](tidyverse/lubridate#829) `%within%` throws more meaningful messages when applied on unsupported classes
* [#831](tidyverse/lubridate#831) Changing hour, minute or second of Date object now yields POSIXct.
* [#869](tidyverse/lubridate#869) Propagate NAs to all internal components of a Period object

### BUG FIXES

* [#682](tidyverse/lubridate#682) Fix quarter extraction with small `fiscal_start`s.
* [#703](tidyverse/lubridate#703) `leap_year()` works with objects supported by `year()`.
* [#778](tidyverse/lubridate#778) `duration()/period()/make_difftime()` work with repeated units
* `c.Period` concatenation doesn't fail with empty components.
* Honor `exact = TRUE` argument in `parse_date_time2`, which was so far ignored.

Version 1.7.4
=============

### NEW FEATURES

* [#658](tidyverse/lubridate#658) `%within%` now accepts a list of intervals, in which case an instant is checked if it occurs within any of the supplied intervals.

### CHANGES

* [#661](tidyverse/lubridate#661) Throw error on invalid multi-unit rounding.
* [#633](tidyverse/lubridate#633) `%%` on intervals relies on `%m+` arithmetic and doesn't produce NAs when intermediate computations result in non-existent dates.
* `tz()` always returns "UTC" when `tzone` attribute cannot be inferred.

### BUG FIXES

* [#664](tidyverse/lubridate#664) Fix lookup of period functions in `as.period`
* [#649](tidyverse/lubridate#664) Fix system timezone memoization

Version 1.7.3
=============

### BUG FIXES

* [#643](tidyverse/lubridate#643), [#640](tidyverse/lubridate#640), [#645](tidyverse/lubridate#645) Fix faulty caching of system timezone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior wip work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed Duration format to correctly display negative values hglanz/lubridate
3 participants
@hadley @hglanz @jfritzemeier