Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vctrs support #66

Merged
merged 25 commits into from
Apr 15, 2019
Merged

vctrs support #66

merged 25 commits into from
Apr 15, 2019

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 18, 2019 •
edited
Loading

Part of #61.

Currently missing:

  • deprecation of as.hms() in favor of new as_hms()
  • vec_cast() for POSIXt (taking the tz attribute from the target)
  • as_hms.POSIXt should use vec_cast()

@krlmlr krlmlr requested a review from hadley February 18, 2019 13:47
hadley
hadley reviewed Feb 18, 2019
View reviewed changes
R/hms.R Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 23, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d77601d). Click here to learn what that means.
The diff coverage is 82.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   92.57%           
=========================================
  Files             ?        9           
  Lines             ?      175           
  Branches          ?        0           
=========================================
  Hits              ?      162           
  Misses            ?       13           
  Partials          ?        0
Impacted Files Coverage Δ
R/round.R 100% <100%> (ø)
R/parse.R 100% <100%> (ø)
R/arith.R 100% <100%> (ø)
R/coerce.R 60% <60%> (ø)
R/cast.R 77.27% <77.27%> (ø)
R/hms.R 95.91% <96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77601d...6d1cafd. Read the comment docs.

@krlmlr
Basics
9a05a37 
- Use _vctrs_ (#61).
- New `new_hms()`, currently doesn't use the class defined by vctrs.
@krlmlr
Use new_duration()
44f7ce7
@krlmlr
vec_ptype_full() and vec_ptype_abbr()
73c22d6
@krlmlr
Casting and coercion
e2e0003 
- `c(hms(), NA)` works now.
- Coercion of numeric and character values to `hms` is deprecated, please use an explicit cast.
@krlmlr
Typo
0e85579
@krlmlr
new_hms() supports numerics only
b34ce37
@krlmlr krlmlr changed the title vctrs support, compatible with current CRAN version vctrs support Mar 25, 2019
@krlmlr krlmlr requested a review from hadley April 6, 2019 22:10
@krlmlr
Copy link
Member Author

krlmlr commented Apr 6, 2019

@hadley: Would you like to take another look?

@krlmlr krlmlr merged commit 60e11f4 into master Apr 15, 2019
@krlmlr krlmlr deleted the f-vctrs-current branch April 15, 2019 17:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @hadley