Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve addition method #297

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Improve addition method #297

merged 3 commits into from
Sep 21, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 27, 2023

Fixes #286

@hadley hadley requested a review from jennybc January 27, 2023 00:10
@@ -1,5 +1,9 @@
# glue (development version)

* `+` now works in more situations, and gives errors when one side isn't a
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, but I doubt that many people relied on the fact that glue("{x}") + "{y}" would also interpolate the RHS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I just learned that this was featured in the README 🙈

@jennybc jennybc merged commit 740ca7f into main Sep 21, 2023
12 checks passed
@jennybc jennybc mentioned this pull request Sep 21, 2023
@jennybc jennybc deleted the strict-addition branch September 22, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Stricter addition
2 participants