Skip to content

Commit

Permalink
Call DBI::Id() without names (#312)
Browse files Browse the repository at this point in the history
* Call Id() without names

* Use dev DBI

* Different way of doing CI against DBI release candidate

---------

Co-authored-by: Jenny Bryan <jenny.f.bryan@gmail.com>
  • Loading branch information
krlmlr and jennybc committed Dec 21, 2023
1 parent ed6a28f commit 84ea088
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 11 deletions.
4 changes: 3 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Imports:
methods
Suggests:
crayon,
DBI (>= 1.1.3),
DBI (>= 1.2.0),
dplyr,
knitr,
magrittr,
Expand All @@ -43,3 +43,5 @@ Config/testthat/edition: 3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3.9000
Remotes:
r-dbi/DBI
10 changes: 5 additions & 5 deletions R/sql.R
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@
#' DBI::dbWriteTable(con, nicknames_db, nicknames)
#'
#' cols <- list(
#' DBI::Id(table = iris_db, column = "sepal_length"),
#' DBI::Id(table = iris_db, column = "sepal_width"),
#' DBI::Id(table = nicknames_db, column = "nickname")
#' DBI::Id(iris_db, "sepal_length"),
#' DBI::Id(iris_db, "sepal_width"),
#' DBI::Id(nicknames_db, "nickname")
#' )
#'
#' iris_species <- DBI::Id(table = iris_db, column = "species")
#' nicknames_species <- DBI::Id(table = nicknames_db, column = "species")
#' iris_species <- DBI::Id(iris_db, "species")
#' nicknames_species <- DBI::Id(nicknames_db, "species")
#'
#' query <- glue_sql("
#' SELECT {`cols`*}
Expand Down
10 changes: 5 additions & 5 deletions man/glue_sql.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 84ea088

Please sign in to comment.