feat(android): add support for Android's API 33 Per-app languages #14120
+74
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansemannn @m1ga a fresh clean PR for the Per-app languages. I kept searching for the test cases so I add to it, couldn't seem to find it tho. |
|
Nice 👍 This looks a lot better now. Will start testing your PRs tomorrow but from a quick first look it looked fine |
|
Will test using this, tho I was thinking about the automated unit testing. Update: The test app is working just fine. |
m1ga
requested changes
Sep 21, 2024
There was a problem hiding this comment.
just some minor string changes you can apply.
I've used my test code from the comment above and works correctly:
- starting the app: empty array as no per-app language is set
- changing it in the app and then going to "app preferences - per-app language" shows the correct value
- changing the value in "app preferences - per-app language" and opening the app shows the correct value in the app
android/modules/locale/src/java/ti/modules/titanium/locale/LocaleModule.java
Outdated
Show resolved
Hide resolved
android/modules/locale/src/java/ti/modules/titanium/locale/LocaleModule.java
Outdated
Show resolved
Hide resolved
…aleModule.java Co-authored-by: Michael Gangolf <m1ga@users.noreply.github.com>
Co-authored-by: Michael Gangolf <m1ga@users.noreply.github.com>
…aleModule.java Co-authored-by: Michael Gangolf <m1ga@users.noreply.github.com>
m1ga
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Android's Per-app languages presented in Android API 33/Android 12.
See Per-app languages preferences