Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node 16 #71

Merged
merged 1 commit into from
Apr 26, 2021
Merged

feat: support node 16 #71

merged 1 commit into from
Apr 26, 2021

Conversation

ewanharris
Copy link
Contributor

This adds support for Node.js 16, I also tested the changes made against 12.13.0, 12.22.0, and 14.6.1.

In summary:

  • Bump to latest node-pre-gyp
  • Remove setting of c++11 stdlib due to V8/Node.js now requiring c++14
  • Updates the usage of AtExit due to compile error on 16
    • This has been a warning since 13.5.0/12.15.0 it appears, and the API has supported 3 arguments since 8.0.0. The version check could potentially be removed in favour of always calling with 3 args
    • As stated in that PR, using AddEnvironmentCleanupHook is preferred, but I figured it was best to stick with whats there already

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! APPROVED!

@cb1kenobi cb1kenobi merged commit 1bc0ea2 into tidev:1_X Apr 26, 2021
@ewanharris ewanharris mentioned this pull request May 4, 2021
@ewanharris ewanharris deleted the node16_support branch June 7, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants