Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added view option for use on ipad #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

added view option for use on ipad #13

wants to merge 3 commits into from

Conversation

aartse
Copy link

@aartse aartse commented Jul 21, 2021

fixes issue #11 "Does not work on iPad".

@build
Copy link

build commented Jul 21, 2021 •
edited
Loading

Messages
📖

✅ All tests are passing
Nice one! All 44 tests are passing.
📖

💾 Here are the artifacts produced:

Generated by 🚫 dangerJS against e851a32

@m1ga m1ga mentioned this pull request Apr 19, 2022
Open
caspahouzer
caspahouzer approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@caspahouzer caspahouzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the functionality, but @aartse has to sign the CLA

@hansemannn
Copy link

@aartse Sorry this to take so long! Can you maybe also bump the version in the manifest and attach the new binary here? Thank you!

@m1ga
Copy link
Contributor

m1ga commented Nov 11, 2022

Build the branch and got feedback that its working fine.
Did to smaller changes:

@aartse if you still like to contribute feel free to make these changes. Otherwise we can create a new PR and get these changes merged

appcelerator.socialshare-iphone-2.0.0.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspahouzer caspahouzer caspahouzer approved these changes

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aartse @build @hansemannn @m1ga @caspahouzer