Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: Record all errors #367

Closed
abhinav opened this issue Aug 14, 2018 · 0 comments
Closed

Logging: Record all errors #367

abhinav opened this issue Aug 14, 2018 · 0 comments

Comments

@abhinav
Copy link
Contributor

abhinav commented Aug 14, 2018

With #366, we fail marshaling for containers and structs when the first item
fails to encode. We should instead use multierr and combine all the errors.
@abhinav abhinav mentioned this issue Aug 15, 2018
Closed
11 tasks
@abhinav abhinav mentioned this issue Aug 27, 2018
Merged
abhinav added a commit that referenced this issue Aug 27, 2018
@abhinav
gen/zap: Record all errors
2cadf77 
when appending/adding an object or array to a Zap encoder, there's a
possibliity of failure. Previously, we were recording the first failure
and returning.

This changes the generated code to rely on `multierr` and collect all
such failures into a single error.

Resolves #367
abhinav added a commit that referenced this issue Aug 28, 2018
@abhinav
gen/zap: Record all errors (#378)
ae73793 
When appending/adding an object or array to a Zap encoder, there's a
possibliity of failure. Previously, we were recording the first failure
and returning.

This changes the generated code to rely on `multierr` and collect all
such failures into a single error.

Resolves #367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinav