Support fast Zap logging (#366)

This adds a `zapcore.MarshalLogObject/Array` method to all generated structs and its underlying components, enums, and non-primitive typedefs, implementing Zap marshalers (i.e. [ObjectMarshaler], [ArrayMarshaler]). For typedefs of primitives, the logging is up to the user, simply by casting it down to the root type and using the respective `Add/Append...` method of the Zap encoder. [ObjectMarshaler]: https://godoc.org/go.uber.org/zap/zapcore#ObjectMarshaler [ArrayMarshaler]: https://godoc.org/go.uber.org/zap/zapcore#ArrayMarshaler
thriftrw · Aug 14, 2018 · 6cfc64a · 6cfc64a
1 parent 53375f1
commit 6cfc64a
Show file tree

Hide file tree

Showing 58 changed files with 4,454 additions and 20 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -6,8 +6,6 @@ go_import_path: go.uber.org/thriftrw
 
 matrix:
   include:
-    - go: 1.7
-    - go: 1.8
     - go: 1.9
     - go: '1.10'
       env: LINT=1

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
-- No changes yet.
+### Added
+- Generated types now implement zapcore.ObjectMarshaler or
+  zapcore.ArrayMarshaler where appropriate. This should lead to much faster
+  logging of these objects.
 
 ## [1.12.0] - 2018-06-25
 ### Added

diff --git a/envelope/internal/tests/enums/types.go b/envelope/internal/tests/enums/types.go
diff --git a/envelope/internal/tests/exceptions/types.go b/envelope/internal/tests/exceptions/types.go
diff --git a/envelope/internal/tests/services/cache_clear.go b/envelope/internal/tests/services/cache_clear.go
diff --git a/envelope/internal/tests/services/cache_clearafter.go b/envelope/internal/tests/services/cache_clearafter.go
diff --git a/envelope/internal/tests/services/conflictingnames_setvalue.go b/envelope/internal/tests/services/conflictingnames_setvalue.go