Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate definition of LinuxMemory #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bensymonds
Copy link

I think this was added accidentally in 5c13458. It generates the following warnings in our app:

vmstat-2.3.1/lib/vmstat/memory.rb:54: warning: method redefined; discarding old available
vmstat-2.3.1/lib/vmstat/memory.rb:54: warning: method redefined; discarding old available=
vmstat-2.3.1/lib/vmstat/memory.rb:58: warning: method redefined; discarding old available_bytes
vmstat-2.3.1/lib/vmstat/linux_memory.rb:9: warning: previous definition of available_bytes was here

I think this was added accidentally in 5c13458. It generates the following warnings in our app:

```
vmstat-2.3.1/lib/vmstat/memory.rb:54: warning: method redefined; discarding old available
vmstat-2.3.1/lib/vmstat/memory.rb:54: warning: method redefined; discarding old available=
vmstat-2.3.1/lib/vmstat/memory.rb:58: warning: method redefined; discarding old available_bytes
vmstat-2.3.1/lib/vmstat/linux_memory.rb:9: warning: previous definition of available_bytes was here
```
@bensymonds
Copy link
Author

@threez Anything I can do to help get this merged? Hoping it's relatively uncontroversial and can be merged and released without much trouble 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant