Add event type as generic in EventDispatcher #468
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add event type as generic in EventDispatcher
Add Support for event types in Object3D, Material, MeshBasicMaterial, MeshPhysicalMaterial, MeshStandardMaterial, ShaderMaterial, BufferGeometry, Camera.
Why
Makes it easier to specify types of events like:
OrbitControls extends EventDispatcher<Event, 'change'|'end'|'start'>
.Also adds generics for Core classes so that event types can be specified when inheriting the three.js classes.
Checklist
master
, next goesdev
)One of my first contributions here. Let me know if anything is wrong. Thanks.