Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1222-DRACOLoader.d.ts-add-parse-function #1223

Merged
merged 1 commit into from
Sep 9, 2024
Merged

#1222-DRACOLoader.d.ts-add-parse-function #1223

merged 1 commit into from
Sep 9, 2024

Conversation

Adamatoma
Copy link
Contributor

  1. parse function was called by load func(load from url, then parse)
  2. In my case, my draco contents are transferred through other ways, load function is useless
  3. Exposing parse function

Methuselah96
Methuselah96 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit eeb32ca into three-types:master Sep 9, 2024
5 checks passed
@Methuselah96 Methuselah96 linked an issue Sep 9, 2024 that may be closed by this pull request
Add interface for parse function to DRACOLoader.d.ts #1222
Closed
@Adamatoma
Copy link
Contributor Author

Thanks!

Btw, when will this pr be published?

@Methuselah96
Copy link
Contributor

It will be published at the end of the month with r169

@Adamatoma Adamatoma deleted the pr-type/#1222-DRACOLoader.d.ts-add-parse-function branch September 10, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interface for parse function to DRACOLoader.d.ts
2 participants
@Adamatoma @Methuselah96