Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability tweaks #22

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Usability tweaks #22

merged 1 commit into from
Feb 18, 2021

Conversation

Jyrno42
Copy link
Contributor

@Jyrno42 Jyrno42 commented Feb 18, 2021

  • Add message attribute to AbstractTransaction
  • Provide request parameter to transaction_succeeded/transaction_failed
  • PaymentRequestBase: Allow usage with existing transaction trough existing_transaction kwarg
    • Note: When using this one must also provde the url kwarg (just send the value of pingpack_url argument provided to create_payment_request)

@Jyrno42
Usability tweaks
718ce9b 
- Add message attribute to AbstractTransaction
- Provide request parameter to transaction_succeeded/transaction_failed
- PaymentRequestBase: Allow usage with existing transaction trough existing_transaction kwarg
  - Note: When using this one must also provde the url kwarg (just send the value of pingpack_url
          argument provided to create_payment_request)
@Jyrno42 Jyrno42 self-assigned this Feb 18, 2021
@Jyrno42 Jyrno42 merged commit 5433513 into thorgate:main Feb 18, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 86.255% when pulling 718ce9b on Jyrno42:usability-tweaks into 0dd1922 on thorgate:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jyrno42 Jyrno42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jyrno42 @coveralls