chore: reorder imports in a consistent way #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 102 102
Lines 3778 3778
=======================================
Hits 3253 3253
Misses 400 400
Partials 125 125 ☔ View full report in Codecov by Sentry. |
thomaspoignant
force-pushed
the
fix-gofmt
branch
2 times, most recently
from
38810f6
to
411399e
Compare
thomaspoignant
commented
Sep 20, 2024
Comment on lines
+753
to
+781
| { | ||
| Kind: "http", | ||
| URL: "https://github.com/thomaspoignant/go-feature-flag/main/examples/retriever_file/flags.goff.yaml", | ||
| HTTPHeaders: map[string][]string{ | ||
| "authorization": []string{ | ||
| "authorization": { | ||
| "test", | ||
| }, | ||
| "token": []string{"token"}, | ||
| "token": {"token"}, | ||
| }, | ||
| }, | ||
| config.RetrieverConf{ | ||
| { | ||
| Kind: "file", | ||
| Path: "examples/retriever_file/flags.goff.yaml", | ||
| HTTPHeaders: map[string][]string{ | ||
| "token": []string{ | ||
| "token": { | ||
| "11213123", | ||
| }, | ||
| "authorization": []string{ | ||
| "authorization": { | ||
| "test1", | ||
| }, | ||
| }, | ||
| }, | ||
| config.RetrieverConf{ | ||
| { | ||
| HTTPHeaders: map[string][]string{ | ||
|
|
||
| "authorization": []string{ | ||
| "authorization": { | ||
| "test1", | ||
| }, | ||
| "x-goff-custom": []string{ | ||
| "x-goff-custom": { |
There was a problem hiding this comment.
this change is because of gofmt
thomaspoignant
force-pushed
the
fix-gofmt
branch
2 times, most recently
from
d9038ac
to
1f06385
Compare
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
fix-gofmt
branch
from
1f06385
to
b8c804b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The project had no safe guards in how the order of imports.
In this PR:
gofmtandgciin the linter.pre-committo be sure that we have the right order all the time.Checklist