Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused format verbs in error messages #2223

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Aug 15, 2024

Description

This PR fixes unused format verbs in error messages.
I noticed that there is unused %v in the message while GitHub is down.
This should be occurred after 306b117.

{"level":"error","ts":1723678691.5177238,"msg":"error while updating the cache: %v\n","error":{"error":"request to...

Closes issue(s)

There is no reported issues.

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 6ace8d9
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66bda766b5910800076fd93d

Copy link

sonarcloud bot commented Aug 15, 2024

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I forgot to address this one when moving to slog.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.00%. Comparing base (2175f5d) to head (6ace8d9).
Report is 2 commits behind head on main.

Files Patch % Lines
feature_flag.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2223   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         102      102           
  Lines        3731     3731           
=======================================
  Hits         3209     3209           
  Misses        399      399           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant merged commit f295af1 into thomaspoignant:main Aug 15, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants