Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relay-proxy): Add the possibility to specify in the evaluation context which flag to evaluate in bulk evaluation flags #2171

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

Add the possibility to specify in the evaluation context which flag to evaluate in bulk evaluation flags.
This applies both in the OFREP Api and in the GOFF Api.

Closes issue(s)

Resolve #2137

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 8e905c4
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66ab8a7a55d95b00083cd4da
😎 Deploy Preview https://deploy-preview-2171--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.00%. Comparing base (427f445) to head (8e905c4).

Files Patch % Lines
variation_all_flags.go 82.35% 3 Missing and 3 partials ⚠️
ffcontext/goff_context_specifics.go 78.94% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
- Coverage   86.10%   86.00%   -0.10%     
==========================================
  Files          99      102       +3     
  Lines        3699     3731      +32     
==========================================
+ Hits         3185     3209      +24     
- Misses        394      399       +5     
- Partials      120      123       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the feature/bulk-evaluation-flags-2137 branch from 1ee3b57 to 4adc9c0 Compare August 1, 2024 12:47
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

sonarcloud bot commented Aug 1, 2024

@thomaspoignant thomaspoignant merged commit 9461a31 into main Aug 1, 2024
21 of 22 checks passed
@thomaspoignant thomaspoignant deleted the feature/bulk-evaluation-flags-2137 branch August 1, 2024 13:22
thomaspoignant added a commit that referenced this pull request Sep 5, 2024
…ontext which flag to evaluate in bulk evaluation flags (#2171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Bulk evaluation provide list of flags to evaluate.
1 participant