Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OFREP): return unsupported types field #1846

Merged
merged 4 commits into from
May 3, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

Add the support of the field unsupportedTypes from OFREP.

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented May 3, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit be38b06
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/663533f7c7748c0008b18e61

Copy link

netlify bot commented May 3, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 5525bfa
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6635352bbe10930008d04b42

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (97f0a16) to head (5525bfa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1846   +/-   ##
=======================================
  Coverage   86.72%   86.72%           
=======================================
  Files          89       89           
  Lines        3367     3368    +1     
=======================================
+ Hits         2920     2921    +1     
  Misses        345      345           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thomaspoignant thomaspoignant merged commit 63fd5dc into main May 3, 2024
21 of 22 checks passed
@thomaspoignant thomaspoignant deleted the ofrep-unsupported-types branch May 3, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant