-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: go 1.21 migration #1208
chore: go 1.21 migration #1208
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Codecov Report
@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
+ Coverage 87.53% 88.60% +1.06%
==========================================
Files 70 70
Lines 3282 3282
==========================================
+ Hits 2873 2908 +35
+ Misses 341 303 -38
- Partials 68 71 +3 see 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@chenrui333 I see that you have bump the version of go to 1.21. |
yeah, we do always build against latest go. |
side note, only go1.20 and go1.21 are supported by go team atm |
Codeql was never useful so I remove it from the CI Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
I've fixed some places where go 1.21 was used. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks @thomaspoignant! |
Description
github.com/nikunjy/rules
to use the go1.21.0
compatible version.Changes include
Closes issue(s)
help Homebrew/homebrew-core#153255
Checklist