Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: go 1.21 migration #1208

Merged
merged 8 commits into from
Nov 3, 2023
Merged

chore: go 1.21 migration #1208

merged 8 commits into from
Nov 3, 2023

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Nov 3, 2023

Description

  • Update go.mod and go.sum for 1.17.0 release
  • Bump github.com/nikunjy/rules to use the go 1.21.0 compatible version.

Changes include

  • Bugfix (non-breaking change that solves an issue)

Closes issue(s)

help Homebrew/homebrew-core#153255

Checklist

Signed-off-by: Rui Chen <rui@chenrui.dev>
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 2e3dde9
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/65455bdb76a8fa00097d4ef8

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1208 (2e3dde9) into main (1f18f93) will increase coverage by 1.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   87.53%   88.60%   +1.06%     
==========================================
  Files          70       70              
  Lines        3282     3282              
==========================================
+ Hits         2873     2908      +35     
+ Misses        341      303      -38     
- Partials       68       71       +3     

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@thomaspoignant
Copy link
Owner

@chenrui333 I see that you have bump the version of go to 1.21.
Any reason why? Is it required by homebrew?

@chenrui333
Copy link
Contributor Author

@chenrui333 I see that you have bump the version of go to 1.21. Any reason why? Is it required by homebrew?

yeah, we do always build against latest go.

@chenrui333
Copy link
Contributor Author

side note, only go1.20 and go1.21 are supported by go team atm

chenrui333 and others added 3 commits November 3, 2023 13:04
Codeql was never useful so I remove it from the CI

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant changed the title fix: update go.mod and go.sum go 1.21 migration Nov 3, 2023
@thomaspoignant thomaspoignant changed the title go 1.21 migration chore: go 1.21 migration Nov 3, 2023
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Copy link
Owner

I've fixed some places where go 1.21 was used.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kodiakhq kodiakhq bot merged commit 11b15c3 into thomaspoignant:main Nov 3, 2023
21 checks passed
@chenrui333
Copy link
Contributor Author

Thanks @thomaspoignant!

@chenrui333 chenrui333 deleted the update-go-sum branch November 4, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants