Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim Whitespace to Fix Pre-Commit Failure #350

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

nbuuckssi
Copy link
Contributor

Proposed changes

#349 failed tests because of trailing whitespace left in the change. This was my mistake for trying to write the change entirely in-browser without cloning locally and running pre-commit, sorry.

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

nbuuckssi and others added 3 commits March 21, 2024 12:19
Adds docs about handling Twisted syslog output and the undocumented `device.listen_addr` configuration option.
@thinkst-francois
Copy link
Contributor

Not a problem thank you for fixing.

@thinkst-francois thinkst-francois merged commit bcb83f9 into thinkst:master Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants