Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsa-sha2-512 and rsa-sha2-256, keys #308

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

emmanuel-thinkst
Copy link
Contributor

Proposed changes

There has been issues the open-canary ssh server, not being able to complete an ssh connection with some clients if they don't offer the "Host Key Algorithms" ssh-rsa and ssh-dss. (#186)
After some testing we found out that, usually if the "Host Key Algorithms" above are not offered, a client would then offer these Algorithms, rsa-sha2-512 rsa-sha2-256, instead.
These changes add support for the "Host Key Algorithms" rsa-sha2-512 rsa-sha2-256, to the open-canary ssh server.

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x] Lint and unit tests pass locally with my changes (if applicable)
  • [ x] I have run pre-commit (pre-commit in the repo)
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • [ x] Linked to the relevant github issue or github discussion

@emmanuel-thinkst emmanuel-thinkst linked an issue Aug 24, 2023 that may be closed by this pull request
@emmanuel-thinkst emmanuel-thinkst merged commit 81124f6 into master Aug 24, 2023
34 checks passed
@emmanuel-thinkst emmanuel-thinkst deleted the 186-couldnt-match-all-kex-parts branch August 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

couldn't match all kex parts
2 participants