Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pcapyng #302

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Move to pcapyng #302

merged 11 commits into from
Aug 22, 2023

Conversation

jayjb
Copy link
Contributor

@jayjb jayjb commented Aug 21, 2023

Proposed changes

This commit makes some improvements to our docker handling for opencanary. The changes include:

  • Added build docker and push to dockerhub
  • Move to pcapy-ng because it is receiving active development
  • Use host for network_mode by default.

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added necessary documentation (if appropriate)

@jayjb jayjb merged commit a94564a into master Aug 22, 2023
34 checks passed
@jayjb jayjb deleted the move_to_pcapyng branch August 22, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants