Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portscan improvements #297

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Portscan improvements #297

merged 2 commits into from
Aug 18, 2023

Conversation

jayjb
Copy link
Contributor

@jayjb jayjb commented Aug 17, 2023

Proposed changes

This commit brings about some improvements to the portscan module.

  1. It allows users to specify a path to the iptables binary via a config setting: portscan.iptables_path
  2. It checks if the system running opencanary has iptables.
  3. if nftables is found, we use iptables-legacy.

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

@thinkst-devdua thinkst-devdua self-requested a review August 18, 2023 08:01
@jayjb jayjb merged commit e8392ef into master Aug 18, 2023
34 checks passed
@jayjb jayjb deleted the portscan_improvements branch August 18, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants