Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid SMTP AUTH when SMTP_USERNAME or SMTP_PASSWORD are empty #585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m124523
Copy link

@m124523 m124523 commented Oct 3, 2024

Proposed changes

Some SMTP servers do not support AUTH. Unconditionally trying to login will result in an exception. Only login when username or password are supplied.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

@CybergalxU
Copy link

I DONT KNOW WHO THE FACK! IS USING THIS PROFILE AND MY GODAMN EMAIL BUT TIME IS UP PAL. IM NOT YOUR FUCKING DOORMAT. ALL THESE FUCKING CANARY TOKENS AND DISCUSSIONS ABOUT SHIT IDK A FUCKING THING ABOUT NEEDS TO STOP. IF I KNEW HOW TO NAVIGATE THIS FUCKED OFF SITE THEN I WOULD ROUTE THIS TO THE RIGHT GODAMN DEPARTMENT BUT INSTEAD IM HAVING TO FLIP THE FUCK OUT ON HERE TO GET SOME GODAMN ATTENTION. THIS IS A FALSE PROFILE. TAKE THE MOTHERFUCKER DOWN BC WHOEVER IT IS IS USING MY FUCKING EMAIL FOR THEIR OWN DOUCHEBAGGERY. IM SIGNING OUT. IVE CHANGED THE PWD. THIS SHOULD BE OVER RIGHT DAMN NOW!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants