Add tests for multiple root key rotation #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also updates the key loader helper in
test_updater_root_rotation_integration.py to load
the new keys too.
The keys were created (at the root of the repository) like
so:
```
from tuf import repository_tool
repository_tool.generate_and_write_ed25519_keypair(
"tests/repository_data/keystore/root_key2", "password")
repository_tool.generate_and_write_ed25519_keypair(
"tests/repository_data/keystore/root_key3", "password")
```
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Test that a client whose root is outdated by multiple versions and who has none of the latest nor next-to-latest root keys can still update and does so by incrementally verifying all roots until the most recent one. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Test that client does not rotate beyond a configured upper bound, i.e. `current_version + MAX_NUMBER_ROOT_ROTATIONS` Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
3 tasks
|
@trishankatdatadog, would you mind giving me a LGTM on these tests that I added for the bug fix you provided in #885? |
trishankatdatadog
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
LGTM, @lukpueh, thanks very much!
Have you tested this PR on both my branch (should ✅), and master (should ❌)?
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu> Co-Authored-By: Trishank K Kuppusamy <33133073+trishankatdatadog@users.noreply.github.com>
lukpueh
force-pushed
the
correctly-rotate-root-test
branch
from
2ef4bed
to
4d7bb69
Compare
Yes I did, and yes it did! :) Thanks for catching the comment mistake. Will merge once the tests ran through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Add tests for bugfix provided by #885.
Description of the changes being introduced by the pull request:
See commit messages for more details.
Please verify and check that the pull request fulfills the following
requirements: