Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove inactive maintainers from MAINTAINERS #1855

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Feb 10, 2022

Fixes #1793

Description of the changes being introduced by the pull request:
As discussed in detail in #1793, maintainer-level (GitHub) permissions should be granted to those who need them, i.e. who actively maintain the project at the moment. The MAINTAINERS.txt file should reflect that state.

It will be reviewed regularly (#1803), and can be changed (e.g. reverted to a prior state) at any time as need arises.

To express our appreciation for past efforts, we might use the Acknowledgement section of the README, and also update it regularly.

In the case of this update: Big kudos to @awwad, @SantiagoTorres and @sechkova for all their valuable contributions to python-tuf!

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

As discussed in detail in theupdateframework#1793, maintainer-level (GitHub)
permissions should be granted to those who need them, i.e. who
actively maintain the project at the moment.
The MAINTAINERS.txt file should reflect that state.

It will be reviewed regularly (theupdateframework#1803), and can be changed (e.g.
reverted to a prior state) at any time as need arises.

To express our appreciation for past efforts, we might use the
Acknowledgement section of the README, and also update it
regularly.

In the case of this update: Big kudos to @awwad, @SantiagoTorres
and @sechkova for all their valuable contributions to python-tuf!

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@coveralls
Copy link

coveralls commented Feb 10, 2022

Pull Request Test Coverage Report for Build 1828388696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.346%

Totals Coverage Status
Change from base Build 1822645525: 0.0%
Covered Lines: 1121
Relevant Lines: 1137

💛 - Coveralls

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. Thank you to the alumni maintainers @awwad @SantiagoTorres @sechkova!

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, but I do like the idea of "emeritus maintainers" or the acknowledgements in README you proposed: would you like to include that change here already?

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh
Copy link
Member Author

lukpueh commented Feb 11, 2022

Looks good to me as well, but I do like the idea of "emeritus maintainers" or the acknowledgements in README you proposed: would you like to include that change here already?

I added an emeritus maintainers section to MAINTAINERS.txt in 16e6f73 and will update the Acknowledgement section with #1807.

@lukpueh lukpueh merged commit 3b135d7 into theupdateframework:develop Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yearly maintainer list cleanup
4 participants