Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata API: Accept X.Y spec_version #1796

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Metadata API: Accept X.Y spec_version #1796

merged 2 commits into from
Feb 8, 2022

Commits on Jan 26, 2022

  1. Metadata API: Accept X.Y spec_version 

    All TUF implementations used to use "1.0" as the spec version and most
of them have never modified that value since.

Accept two-part spec_version for legacy compatibility: it is strictly
speaking against the current spec (which requires semver) but there
should be no harm in doing this and it allows us to deserialize
metadata generated by e.g. go-tuf.

Fixes theupdateframework#1751

Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
    Jussi Kukkonen committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    572084e View commit details
    Browse the repository at this point in the history

  2. tests: Fix invalid signed serialization tests 

    Most of the test_invalid_signed_serialization subtests are currently
failing because "_type": "signed" and then the test tries to deserialize
them as Snapshot (which fails a type check).

Correct the type to "snapshot" so that we can fail in the correct places
during serialization instead.

Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
    Jussi Kukkonen committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    1695622 View commit details
    Browse the repository at this point in the history