Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use builtin package cache support #1718

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

jku
Copy link
Member

@jku jku commented Dec 9, 2021

actions/setup-python now supports pip cache: use that instead of
handling cache locations manually.

Cache invalidates when any requirements file changes (same as before):
this is a bit over cautious but probably harder to break.

Fixes #1692

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

actions/setup-python now supports pip cache: use that instead of
handling cache locations manually.

Cache invalidates when any requirements file changes (same as before):
this is a bit over cautious but probably harder to break.

Fixes theupdateframework#1692

Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1558409747

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.581%

Totals Coverage Status
Change from base Build 1554266096: 0.0%
Covered Lines: 4032
Relevant Lines: 4116

💛 - Coveralls

@jku
Copy link
Member Author

jku commented Dec 9, 2021

Did some forced rebuilds and this seems to work as expected: caches are stored per operating system and they are found in later builds

@jku jku marked this pull request as ready for review December 9, 2021 11:12
@sechkova
Copy link
Contributor

I'd like to approve but can someone with more knowledge on GH Actions have a look? @kairoaraujo @joshuagl

@kairoaraujo
Copy link
Collaborator

LGTM

@jku jku merged commit 4f8d494 into theupdateframework:develop Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement native support from GHA for pip caching with python-setup.
4 participants