Fix inconsistent behaviour of compute_metafile_hashes_length #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1536041178
💛 - Coveralls |
sechkova
reviewed
Nov 24, 2021
ivanayov
force-pushed
the
repository_simulator_inconsistent_metafile_hashes
branch
from
e9ac81c
to
2dc00ee
Compare
sechkova
suggested changes
Nov 29, 2021
ivanayov
force-pushed
the
repository_simulator_inconsistent_metafile_hashes
branch
2 times, most recently
from
479874e
to
68d788d
Compare
Previously when `compute_metafile_hashes_length` was set to `False` `update_timestamp` did not set the hash and length values to `None` as expected. This change fixes that, so they are not `None` when `compute_metafile_hashes_length=True` and `None` when `compute_metafile_hashes_length=False` Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
ivanayov
force-pushed
the
repository_simulator_inconsistent_metafile_hashes
branch
from
68d788d
to
71a7f11
Compare
sechkova
approved these changes
Dec 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when
compute_metafile_hashes_lengthwas set toFalseupdate_timestampdid not set the hash and length values toNoneas expected. This change fixes that, so they are not
Nonewhencompute_metafile_hashes_length=TrueandNonewhencompute_metafile_hashes_length=FalseFixes #1651