Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents delegate role name as top-level role name #1690

Commits on Nov 22, 2021

  1. Prevents delegate role name as top-level role name

    This commit adds the validation in the ``metadata.Delegations``
    to prevent that one of the delegate role names given is a top-level
    role name.
    
    A ``ValueError`` will be raised if one of the roles names in the
    list given to as delegated contains the role name as one of the
    top-level roles.
    
    Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
    Kairo de Araujo committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    f5bf6b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Fix reuse datasets/tests, better keyids, standards

    - Reuse the dataset and the existing tests
    - Fix the keyids in the tests datasets to be aligned
    - Fix the ``ValueError`` message aligned to the existent messages
    
    Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
    Kairo de Araujo committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    597fc88 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Ccheck empty strings, remove comprehensive lists

    - Add the check for empty strings in the Delegate Role name
    - Remove the comprehensive lists to make the code more readable
    - Remove the test for empty file name from
    ``test_updater_with_simulator``
    
    Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
    Kairo de Araujo committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    b6c482e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Remove the unnecessary set()

    The set() is not required in the OrderedDict.
    
    Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
    Kairo de Araujo committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    72d68f3 View commit details
    Browse the repository at this point in the history