-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pylintc for new code: disable format checker #1659
pylintc for new code: disable format checker #1659
Conversation
By default pylint does format checks: https://pylint.pycqa.org/en/latest/technical_reference/features.html?highlight=format#format-checker The problem is we also use black and isort who have format checkers as well. This makes pylint format checks obsolete. Also, it's possible that you would want to disable a warning and you can end up in the situation where you will have to disable it for two tools altogether. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
As Jussi has pointed out, even the pylint project had disabled |
Pull Request Test Coverage Report for Build 1425820471
💛 - Coveralls |
I am finding more and more checks for pylint that overlap with what black @jku do you think we should disable those checks? |
If the checks are problematic, then sure why not. But let's not disable things if they're working fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this:
- black seems to do a good job of format enforcement
- if we need to add local disables (like we'd like to in some test code), having two checkers for the same thing is problematic
Locally I noticed a couple of warnings from pylint when I wanted to prepare a pr for pylint. |
Now that I think about it... you could remove the format checker configuration section from pylintrc as well: if it does not get used, it should not be there |
The "FORMAT" section in pylint is no longer needed after the format checker is disabled. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
Description of the changes being introduced by the pull request:
By default pylint does format checks:
https://pylint.pycqa.org/en/latest/technical_reference/features.html?highlight=format#format-checker
The problem is we also use black and isort who have format checkers as
well. This makes pylint format checks obsolete.
Also, it's possible that you would want to disable a warning and you
can end up in the situation where you will have to disable it for
two tools altogether.
Signed-off-by: Martin Vrachev mvrachev@vmware.com