Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load full target file info for delegated targets metadata #1049

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Load full target file info for delegated targets metadata #1049

merged 2 commits into from
Jun 9, 2020

Conversation

sechkova
Copy link
Contributor

@sechkova sechkova commented Jun 9, 2020

Fixes issue #: #1046

Description of the changes being introduced by the pull request:

  • Fix load_repository() to actually load the full targets file info from file system for delegated targets.
  • Update _load_top_level_metadata() to load targets and delegated targets metadata in a consistent way.
  • Add a test case checking if targets file info is loaded correctly.

Please verify and check that the pull request fulfills the following
requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@sechkova
Load full target file info for delegated targets
88f6755 
Fix load_repository to actually load the full targets file info from
file system for delegated targets.

Update _load_top_level_metadata to load targets and delegated targets
metadata in a consistent way.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
@sechkova
Update test_load_repository
2553dff 
Extend test_load_repository to check if targets file info is loaded
correctly.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
trishankatdatadog
trishankatdatadog approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not looked at the backend repository tools code, but LGTM

woodruffw
woodruffw approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks a ton @sechkova!

lukpueh
lukpueh approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is even better than my one-liner. Many thanks for the clean patch and for adding tests too, @sechkova! The Travis failures seem to be unrelated. Merging...

@lukpueh lukpueh merged commit ff5afe4 into theupdateframework:develop Jun 9, 2020
@sechkova
Copy link
Contributor Author

At your service 😁

@sechkova sechkova deleted the issue-1046 branch June 10, 2020 08:05
@di di mentioned this pull request Feb 1, 2022
Open
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukpueh lukpueh lukpueh approved these changes

@woodruffw woodruffw woodruffw approved these changes

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sechkova @lukpueh @woodruffw @trishankatdatadog