Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SKIP CI] run-all-test: make similar test cases with pr test #1019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SKIP CI] run-all-test: make similar test cases with pr test #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions test-case/run-all-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ very_short_tests()


testlist="
kernel-boot-log
tplg-binary
pcm_list
sof-logger
Expand All @@ -31,17 +32,18 @@ playback-d1l100r1
capture_d1l100r1
playback_d1l1r50
capture_d1l1r50
playback_all_formats
capture_all_formats
speaker
runtime-pm-status
pause-resume-playback
pause-resume-capture
volume
signal-stop-start-playback
signal-stop-start-capture
xrun-injection-playback
xrun-injection-capture
simultaneous-playback-capture
multiple-pipeline-playback
multiple-pipeline-capture
multiple-pipeline-all
multiple-pause-resume
kmod-load-unload
kmod-load-unload-after-playback
Expand Down Expand Up @@ -169,6 +171,10 @@ interrupted_results()
exit 1
}

test_kernel-boot-log()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @greg-intel , please no mix in the same name.

Suggested change
test_kernel-boot-log()
test_kernel_boot_log()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaning towards renaming the few tests that have underscores to be dashes, as 95% of our tests are named using dashes. I'm not sure how the underscore tests got through, I don't remember seeing them...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaning towards renaming the few tests...

Consistency and simplicity are good and should absolutely be a goal for new code or code that is changing anyway for other reasons.

For unchanged code it's much more questionable. Is it worth the git churn and potential git conflicts with PRs in progress, branches, etc? It depends.

{
"$mydir"/verify-kernel-boot-log.sh
}
test_firmware-presence()
{
"$mydir"/verify-firmware-presence.sh
Expand Down Expand Up @@ -223,10 +229,22 @@ test_capture_d1l1r50()
{
"$mydir"/check-capture.sh -d 1 -l 1 -r "$large_round"
}
test_playback_all_formats()
{
"$mydir"/check-playback.sh -d 3 -l "$small_loop" -r 1 -F
}
test_capture_all_formats()
{
"$mydir"/check-capture.sh -d 3 -l "$small_loop" -r 1 -F
}
test_speaker()
{
"$mydir"/test-speaker.sh -l "$medium_loop"
}
test_runtime-pm-status()
{
"$mydir"/check-runtime-pm-status.sh -d 10
}
test_pause-resume-playback()
{
"$mydir"/check-pause-resume.sh -c "$large_count" -m playback
Expand Down Expand Up @@ -271,6 +289,10 @@ test_multiple-pipeline-capture()
{
"$mydir"/multiple-pipeline-capture.sh -l "$medium_loop"
}
test_multiple-pipeline-all()
{
"$mydir"/multiple-pipeline.sh -f p -c 20
}
test_multiple-pause-resume()
{
"$mydir"/multiple-pause-resume.sh -l "$small_loop" -r 25
Expand Down