feat(ipns-infra): IPNS publishing #2731
Conversation
tx0c
force-pushed
the
feat/ipns-publishing
branch
6 times, most recently
from
4b606a0
to
63c3535
Compare
Codecov ReportBase: 52.28% // Head: 52.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2731 +/- ##
===========================================
- Coverage 52.28% 52.12% -0.17%
===========================================
Files 431 432 +1
Lines 11183 11249 +66
Branches 2390 2401 +11
===========================================
+ Hits 5847 5863 +16
- Misses 5332 5382 +50
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tx0c
force-pushed
the
feat/ipns-publishing
branch
2 times, most recently
from
65bba99
to
90a44a0
Compare
| method: 'POST', | ||
| body: formData, | ||
| }) | ||
| console.log(new Date(), 'key/import res:', res) |
There was a problem hiding this comment.
Is there any sensitive data that needs to be masked?
There was a problem hiding this comment.
no; the sample looks like this:
2022-09-12T18:42:59.223Z key/import fetch res: {
Name: 'ed-gen-test23-4-1663008179217',
Id: 'k51qzi5uqu5dhdb6i7umgq6xcu5wt4appzz1c1kyqgh8folsecogs56j11if8n'
}There was a problem hiding this comment.
many console log lines for debugging in the beginning days when running on dev; but eventually (in 2 ~ 4 weeks range) will be cleaned up
tx0c
force-pushed
the
feat/ipns-publishing
branch
2 times, most recently
from
24148c7
to
a608d06
Compare
| const imported = await res.json() | ||
| console.log(new Date(), 'key/import res json:', imported) | ||
| // return res.json() | ||
| return imported |
There was a problem hiding this comment.
there is ipfs.key.import method, accept password
https://github.com/ipfs/js-ipfs/blob/master/docs/core-api/KEY.md#ipfskeyimportname-pem-password-options
but the problem is only for js-ipfs implementation, different than go-ipfs
In a bit more detail, js-IPFS accepts the key as a query string argument, go-IPFS accepts it in the body of the POST request.
tx0c
force-pushed
the
feat/ipns-publishing
branch
9 times, most recently
from
2aa3138
to
7dbc7ca
Compare
partI for #2631 each author's json feed is like: <any-ipfs-gateway>/ipns/{key}/feed.json
partI for #2631