Fix backup man future registration and BackupStatus computation of the node backup state #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e node backup state
adejanovski
force-pushed
the
fix-backup-status-tracking-futures
branch
from
5a1a290
to
745dc60
Compare
|
|
@rzvoncek, this is ready for review. I added some tests to check the behavior and manually checked that it works as expected in K8ssandra. |
rzvoncek
approved these changes
Aug 15, 2024
|
I've retriggered the tests and they both passed. |
rzvoncek
pushed a commit
that referenced
this pull request
Aug 15, 2024
…e node backup state (#799) * Fix backup man future registration and BackupStatus computation of the node backup state * Attempt at using docker compose v2 * Handle future result * add logging to understand how the future behaves * Fix exception using a wrong method on futures
SoaigM
pushed a commit
to SoaigM/cassandra-medusa
that referenced
this pull request
Aug 23, 2024
…e node backup state (thelastpickle#799) * Fix backup man future registration and BackupStatus computation of the node backup state * Attempt at using docker compose v2 * Handle future result * add logging to understand how the future behaves * Fix exception using a wrong method on futures
SoaigM
pushed a commit
to SoaigM/cassandra-medusa
that referenced
this pull request
Aug 23, 2024
…e node backup state (thelastpickle#799) * Fix backup man future registration and BackupStatus computation of the node backup state * Attempt at using docker compose v2 * Handle future result * add logging to understand how the future behaves * Fix exception using a wrong method on futures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #797
Two bugs are fixed in this PR:
BackupMan.register_backup()function was always registering the backup, even if it existed and overwrite was set to false due to bad code structure.