Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ruff pre-commit hook version #1220

Closed
wants to merge 1 commit into from

Conversation

afuetterer
Copy link
Contributor

Description

Hi, this is my first PR to the project. Please let me know, if the changes are desired.

This PR bumps the ruff version in your pre-commit config. With that change the configuration needs to be updated as well to silence a few warnings (e.g. their is now a section tool.ruff.lint).

A few rule changes make the codebase now fail the linting step. Would you like to me to fix those? What do you think?

See: https://docs.astral.sh/ruff/configuration/

How has this been tested?

Closes

@michalk8
Copy link
Collaborator

Thanks a lot, I included your changes in #1223 !

@michalk8 michalk8 closed this Sep 15, 2024
@afuetterer afuetterer deleted the ruff branch September 16, 2024 16:32
@afuetterer
Copy link
Contributor Author

Hi @michalk8, in your pre-commit config you have pyupgrade, isort, black and ruff. You can replace a few or all of these with ruff, if you prefer fewer dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants