Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element.text(textValue) fails with Missing 'text' parameter failure on Firefox #144

Closed
cuff-links opened this issue May 16, 2018 · 2 comments
Closed

element.text(textValue) fails with Missing 'text' parameter failure on Firefox #144

cuff-links opened this issue May 16, 2018 · 2 comments
Assignees
@cuff-links

Comments

@cuff-links
Copy link
Contributor

**Failure Environment: **
Leadfoot 1.7.5
Browser: FF 59
Driver: Geckodriver 20
OS: Mac OSX High Sierra

[Stack Trace)(https://gist.github.com/silne30/f54cf35ddcafb51fc9d4a05b983d6f74)

Passed Environment
Leadfoot 1.7.5
Browser: Chrome 65
Driver: Chromedriver 2.36

The same test passes on Chrome. Not using the Intern.
@cuff-links
Copy link
Contributor Author

I did some digging. Geckodriver has updated to the current spec whereas Chromedriver hasn't. The parameter was previously called value but has now been changed to text. I will submit a PR with the fix. This is similar to #143 and will likely need a similar fix.

Please assign to me.

This was referenced May 19, 2018
Closed
Closed
Closed
jason0x43 pushed a commit that referenced this issue Jul 17, 2018
@jason0x43
Handle text parameter Element#type
fda2777 
fixes #144
jason0x43 added a commit that referenced this issue Jul 23, 2018
@jason0x43
Handle text parameter for Element#type
830f956 
references #144
@cuff-links
Copy link
Contributor Author

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuff-links cuff-links

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cuff-links