Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tslib to 1.10 #1003

Closed
wants to merge 1 commit into from
Closed

Conversation

devpaul
Copy link
Contributor

@devpaul devpaul commented Dec 11, 2019

VSCode was producing a warning when using an array spread:

image

The __spreadArrays method was added to tslib 1.10 and used by TS as an improvement on array spreads w/o downlevel iteration. This applies to Intern. (though we may be getting lucky as the compiler doesn't use __spreadArrays for simple instances).

@devpaul
Copy link
Contributor Author

devpaul commented Dec 11, 2019

This warning is due to VSCode using it's own internal version of TS (3.6) rather than the workspace's version by default. After switching to use the workspace's TS the error goes away!

We can address this later when we update TS.

@devpaul devpaul closed this Dec 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #1003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1003   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files          60       60           
  Lines        4887     4887           
  Branches     1088     1088           
=======================================
  Hits         3269     3269           
  Misses       1618     1618

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430ac0a...57d8cf0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants