Remove systemd from puppet::agent::service case
#768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like theforeman#498 had a breaking change when it added an Enum for `runmode` that didn't include `systemd` (only `systemd.timer`) But that was a long time ago, so just tidying the code in `puppet::agent::service`, instead of ammending the `Enum` in `init.pp`.
ekohl
approved these changes
Oct 6, 2020
|
Test failures should be fixed in #767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #498 had a breaking change when it added an Enum for
runmodethat didn't includesystemd(onlysystemd.timer)But that was a long time ago, so just tidying the code in
puppet::agent::service, instead of ammending theEnumininit.pp.