Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set more data types and document classes & defines #663

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Set more data types and document classes & defines #663

merged 3 commits into from
Jan 10, 2019

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 27, 2018

No description provided.

@mmoll
Copy link
Contributor

mmoll commented Dec 29, 2018

@ekohl tests fail 💔

@mmoll
Copy link
Contributor

mmoll commented Dec 30, 2018

@ekohl now it needs a rebase :)

@ekohl
Copy link
Member Author

ekohl commented Jan 10, 2019

Rebased

@mmoll mmoll merged commit 659253d into theforeman:master Jan 10, 2019
@mmoll
Copy link
Contributor

mmoll commented Jan 10, 2019

merged, bedankt @ekohl!

@ekohl ekohl deleted the data-types branch January 11, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @mmoll @theforeman-bot