Add Puppet 6 support #642
Merged
Add Puppet 6 support #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: we should drop the debian8 beaker tests in favor of debian9. Going to let this continue though to see what's going to happen. |
ekohl
force-pushed
the
puppet-6
branch
2 times, most recently
from
7f66750
to
500afba
Compare
The only difference is the 6 CA generation and that we need _core repos as fixtures because the gem doesn't include the vendored modules. While we're at it, we also add Puppet 5 acceptance tests but because of a lack of packages we skip: * Debian 8 + puppet5 / puppet6 * Debian 9 + pc1
|
This should now be ready to go. I didn't add Ubuntu acceptance tests because they were failing with a timeout and I haven't had time to investigate. That shouldn't hold back this PR though because it was also timing out on Puppet 5. |
|
merged, bedankt @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with theforeman/foreman-installer-modulesync#92