Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for the correct line endings on Windows #640

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Test for the correct line endings on Windows #640

merged 1 commit into from
Oct 15, 2018

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 15, 2018

No description provided.

@ekohl ekohl mentioned this pull request Oct 15, 2018
Merged
@mmoll
Copy link
Contributor

mmoll commented Oct 15, 2018

spec/classes/puppet_config_spec.rb probably also needs a modification.

@ekohl
Copy link
Member Author

ekohl commented Oct 15, 2018

This is quite ugly but IMHO less ugly than the alternative of including \r?\n. Note that $ also doesn't work because there's a \r there. Not sure if there's a better way.

@mmoll
Copy link
Contributor

mmoll commented Oct 15, 2018

it's 💚

@mmoll mmoll merged commit dae8342 into theforeman:master Oct 15, 2018
@mmoll
Copy link
Contributor

mmoll commented Oct 15, 2018

merged, bedankt @ekohl!

@ekohl ekohl deleted the windows-line-endings branch November 19, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @mmoll @theforeman-bot