Add shared gem path for Puppetserver >= 5.3

[baurmatt]

Since 5.3.0 Puppet Server can use some gems shipped by puppet-agent. For
this the gem-path settings of puppetserver.conf needs to be extend by
/opt/puppetlabs/puppet/lib/ruby/vendor_gems. This is the default as
shipped by Puppetlabs.

Fixes GH-630.

[ekohl]

Haven't verified this, but the code looks correct.

[baurmatt]

Tests failures aren't related. Seems like master is broken as well.

[mmoll]

The hard-coded path will probably break on e.g. FreeBSD, so either a variable for the whole path should get introduced or (if that's possible) it should get deduced from a fact...

[baurmatt]

Good point! :) But to be honest, I have no idea what the correct path would be for FreeBSD nor do I have a FreeBSD around to take a look. Could it be /usr/local/share/puppet/lib/ruby/vendor_gems?

Using a parameter would be nice

[mmoll]

puppetserver6 came into the FreeBSD ports collection and that dir is simply not included:

-    gem-path: [${jruby-puppet.gem-home}, "/opt/puppetlabs/server/data/puppetserver/vendored-jruby-gems", "/opt/puppetlabs/puppet/lib/ruby/vendor_gems"]
+    gem-path: [${jruby-puppet.gem-home}, "/var/puppet/server/data/puppetserver/vendored-jruby-gems"]

[mmoll]

Also, I'd rather would use >= 6.0 as version constraint, at least for now.

[baurmatt]

FreeBSD: I think that's an error of the package maintainer. The puppetserver.conf file is explicitly managed by the package, see https://svnweb.freebsd.org/ports/head/sysutils/puppetserver5/files/patch-ext__config__conf.d__puppetserver.conf?revision=465587&view=markup. I don't see any reason why the (correct) path shouldn't be included for FreeBSD.

Edit: Ok, seems like FreeBSD basically does a Source installation which doesn't include the vendor_gems path. I will fix that.

6.0 >=: Can you explain why? The gem-path setting was updated by Puppetlabs with 5.3, this module should reflect that.

[baurmatt]

Updated the PR so that the gem-path setting for FreeBSD doesn't include the path to vendor_gems

[mmoll]

FreeBSD: I think that's an error of the package maintainer.

While I have no information about the brackgorund, the default for FreeBSD's puppetservers is not to include that path, so we should just mirror that.

6.0 >=: Can you explain why? The gem-path setting was updated by Puppetlabs with 5.3, this module should reflect that.

Sorry, mixed this up with another PR. 5.3 is correct. 👍

[mmoll]

Untested, but looks OK. We can add a specific paramter, later if it should really be needed.

[ekohl]

Thanks!