Use foreman apache configs to unblock Pulp 3 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
commented
Feb 14, 2020
|
@ekohl general thoughts on this overall approach? It is related to this change theforeman/forklift#1105 |
ekohl
reviewed
Feb 14, 2020
There was a problem hiding this comment.
In my local dev env I have a WIP patch that attempted to do the same thing but it looks like I never finished that. It was certainly my intention to use it this way. I also thought about refactoring the class slightly in puppet-foreman to make it easier to consume. We can do that by not having defaults inheriting from foreman but rather working defaults. Then in the foreman::config class we explicitly set the parameters.
|
I'd like to see a version that uses theforeman/puppet-foreman#800 because it should be simpler. |
ehelms
force-pushed
the
use-foreman-apache
branch
2 times, most recently
from
56b9b5e
to
3aba7cf
Compare
ekohl
reviewed
Feb 19, 2020
ehelms
force-pushed
the
use-foreman-apache
branch
from
3aba7cf
to
df136e6
Compare
ehelms
force-pushed
the
use-foreman-apache
branch
from
df136e6
to
b89fe3a
Compare
|
All cleaned up and ready to party |
ekohl
approved these changes
Feb 19, 2020
| @@ -178,37 +178,9 @@ | |||
| require => Class['katello_devel::database'], | |||
| } | |||
|
|
|||
| User<|title == $user|>{groups +> 'qpidd'} | |||
|
|
|||
| # TODO: Use katello::pulp | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module had declared it's own vhost using a similar naming convention and directory structure as Foreman's. This causes a conflict when pulpcore is enabled since pulpcore relies on adding fragments to Foreman's vhost declaration specifically around the use of
05-foreman-ssl.d. To solve this, and bring greater continuity I have attempted to declare theforeman::config::apacheclass and re-use it here.