Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #30535 - Correctly unset remote user groups #896

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Refs #30535 - Correctly unset remote user groups #896

merged 1 commit into from
Oct 22, 2020

Conversation

tbrisker
Copy link
Member

This corrects a typo in the previous change, which unset
REMOTE_USER_USER_GROUPS instead of REMOTE_USER_GROUPS in the apache
configuration.

@tbrisker
Refs #30535 - Correctly unset remote user groups
daab7aa 
This corrects a typo in the previous change, which unset
REMOTE_USER_USER_GROUPS instead of REMOTE_USER_GROUPS in the apache
configuration.
@tbrisker tbrisker mentioned this pull request Oct 22, 2020
Merged
ekohl
ekohl approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I broke the tests when I merged db41ee8. I just pushed 79806f7 and trust that I won't make the same mistake again by merging something that breaks CI.

@ekohl ekohl merged commit 6dea3b7 into theforeman:master Oct 22, 2020
@ekohl ekohl added the Bug label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Bug Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbrisker @ekohl @theforeman-bot