Add certname to error output in external_node_v2.rb #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with debugging and gives error output more context. For
example Foreman will not accept pushed facts for a host that is
currently being built. With this change the error message changes from
this:
During the fact upload the server responded with: 422 Unprocessable Entity. Error is ignored and the execution continues.
{"message":"ERF42-9911 [Foreman::Exception]: Host is pending for Build"}
To this, which is preferable:
app03.dev.example.com: During the fact upload the server responded with: 422 Unprocessable Entity. Error is ignored and the execution continues.
{"message":"ERF42-9911 [Foreman::Exception]: Host is pending for Build"}
|
The test failures seem unrelated to the changes in this PR. |
|
merged, thanks @antaflos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with debugging and gives error output more context. For
example Foreman will not accept pushed facts for a host that is
currently being built. With this change the error message changes from
this:
To this, which is preferable: